QR code website challenge made with HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  div.central_block {
  margin: 70px auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Wyatt Haak•60

  @WH-DesignsPosted over 1 year ago

  Hey Lucas, you did very well with this challenge, there are many ways to center a div with css, and the way you did it used one method using Margin: auto; which will center the div depending on how the div is displaying, if that be display: block; or display: inline;

  I would recommend that you also take a look at flex box and learning the basics of that because it is another way of centering an element but also allows for so much more flexibility with mobile and desktop screens.

  Marked as helpful

  1