QR Code Web

Hello there 👋. Congratulations on successfully completing your first challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

• Use semantic elements such as <main> instead of <div class="container"> to improve accessibility and organization of your page.

• Use HTML5 semantic elements such as <header>, <nav>, <main>, <aside>, and <footer> to define these sections

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!

Replace <div class="container"> with the main tag and <p class="improve-msg"> with <h1> to fix the accessibility issue. click here for more on web-accessibility and semantic html

To center .container on the page using flexbox or grid, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

USING FLEXBOX:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

USING GRID:
body{
min-height: 100vh;
display: grid;
place-items: center;
}

For a responsive content give .container a fixed max-width value and padding value for all the sidesmax-width:320px padding:16px and a border-radius value.

Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.

Give the img a max-width of 100% instead of a width and height value.

Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here Hope am helpful.

Well done for completing this challenge. HAPPY CODING