QR CODE

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @nade12209!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  Kirsten ✨•460

  @ofthewildfirePosted 9 months ago

  Welcome! Looks like its your first challenge

  Looks good, however it should be centered, you can do that easily by just using Flexbox on the body. I also noticed that your class names, have no meaning, a class name should have some meaning to the element.

  display: flex;
  justify-content: center;
  align-items: center;
  min-height: 100vh;
  

  Your QR code is also missing an alt tag.

  Good luck!

  0