Qr code viewer using HTML and CSS

Community feedback

• 

  Adrian H•420

  @AdrianX19Posted over 2 years ago

  Hi @jamespaulmiranda!

  Welcome on frontendmentor and congrats for submitting your first challenge! :) a few suggestions:

  • to get rid off the accessibility/html issues there are two things you should do, first use semantic tags, so instead of having 'div' for your container use 'main', and instead of having 'div' for your footer, well.. you can use 'footer' tag! :). Second thing is the h3 you used, heading levels shouldn't be used for the styling purpose, it's just not a good practice and we have CSS for that purpose! so changing h3 to h1 and changing the fontsize through CSS would do the trick
  • you might consider giving some min-width to your card so it doesn't get squeezed so much with smaller viewport width
  • you seem to be lacking the mobile version, you can achieve it on many ways but using media queries it's a good call most of the times! (https://www.w3schools.com/css/css_rwd_mediaqueries.asp) :)

  Have a good day! :)

  Marked as helpful

  0

  ---

  

  James•10

  @jamespaulmirandaPosted over 2 years ago

  @AdrianX19 Thank you for the feedback. With those 3 points, I really learned a lot.

  0