Debabrata Banik• 590
@DebabrataBanik
Posted
Great job on completing the challenge! A few suggestions for improvement:
- Moving the footer element inside the body tag to ensure proper html strcuture.
- Consider using 'em' or 'rem' for font sizes instead of absolute units.
- Addinig an alt text to the QR code image for improving accessibility. Something like 'QR code linking to Frontend Mentor' will do.
- Try to avoid fixed dimensions that restrict component flow. eg. setting a min-height to container instead of a fixed height which is resulting in the overflowing of the content on smaller viewports.
Marked as helpful
0
