@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
Metadata 🗃️:
-
The
viewportmeta tag is missing. theviewportmeta tag is used to control the layout of the page on mobile devices. Add theviewportmeta tag to the<head>tag:<meta name="viewport" content="width=device-width, initial-scale=1.0">.You can check your solution on a mobile device to see how your solution is distorted by not using this tag. ⚠️
Alt text 📷:
-
To make the alt attribute as useful and effective as possible, avoid using words such as "image", "photo", or "picture" as they are redundant because the image tag already conveys that information. Instead, try to make the description as human-readable and understandable as possible.
The alt attribute should explain the purpose of the image, for example, in the case of a QR code, a description like "qr code to frontendmentor.io" would be more appropriate.
If you want to learn more about the
altattribute, you can read this article. 📘.
CSS 🎨:
-
Instead of using pixels in font-size, use relative units like
emorrem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘. -
Use
align-items: center;andmin-height: 100vh;to center the component.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@QuentinPetton
Posted
Thank you @MelvinAguilar for this very comprehensive response and the additional ressources ! I was able to make the improvements. Have a great evening !
