QR Code using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with Image is not Avaialble is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1
• 

  Basit Korai•350

  @basitkoraiPosted over 1 year ago

  Hi, my friend how are you?

  Congratulations on completing the project.

  Your layout is so responsive, and I approve of it.

  But I have suspected your layout is breaking on smaller screens, you shouldn't set explicit height on the card. My tip is to avoid setting an explicit height on any element unless you really have to.

  • Because of explicit height, your content will overflow and will cause unnecessary scrollbars to appear. Just remove it, and you'll be good to go.

  Besides that, everything looks good to me.

  Hope it helps to be a better developer 😊

  Upvote the comment if it helps

  1

  ---

  

  Sanket Deshmukh•10

  @sanketdeshmukh1Posted over 1 year ago

  Hi@basit-flash thanks for taking out your time and give me valuable suggestion, I made few changes as per your suggestion. Keep Helping me and other people here.

  0