@correlucas
Posted
πΎHi @vincemarq01, congratulations on your solution!π Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw youβre on the right track. Iβve few suggestions for you that you can consider adding to your code:
1.When you download the project files thereβs a file called style-guide.md
where you can find information such as hsl color codes
and the font-size
for the headings. The background-color in this case is background-color: #D5E1EF
2.Improve your html markup using meaningful tags and replace the important blocks of content with better tags, for example the main div that takes all the content can be wrapped with <main>
or section, the cards you can be replaced the <div>
that wraps each card with <article>
you can wrap the paragraph with the quote with the tag <blockquote>
this way you'll wrap each block of element with the best tag in this situation. Donβt use div
for the important blocks, ever prefer some tag that shows what its containing the block.
Here's a complete guide for HTML semantic TAGS: https://www.w3schools.com/TAgs/default.asp
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
βοΈ I hope this helps you and happy coding!
Marked as helpful
@vincemarq01
Posted
@correlucas Thank you lucas