QR code using HTML and CSS

Community feedback

• 

  hilmi77•250

  @hilmi77Posted 8 months ago

  Hello @NosheenMumtaz !

  Your Solution looks good🎉

  There are different ways to upload your project to the live site. You can use Github , netlify and Vercel.

  Mostly FEM users use Github

  this link will help you https://www.youtube.com/watch?v=Bzwlt3qf1dM

  and ı review your solution

  center a container you can use flex grid etc. for example you want to use flex to center a div you can give min-height:100vh display: flex; justify-content: center; align-items: center;

  if you find useful this comment please click "Marked as helpful"

  Happy coding

  Marked as helpful

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 8 months ago

  Hello @NosheenMumtaz!

  Your solution looks great!

  I have a suggestion for improvement:

  📌 Think about using <main> to wrap your main content instead of <div>.

  Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.

  This change might not have impact on how your page looks, but it'll make your HTML code clearer and help with SEO and accessibility.

  Hope that's helpful!

  Keep up the great work!

  Marked as helpful

  0