Design comparison
Community feedback
- @Rami-HegazyPosted 10 months ago
Hey Sandeep, There are some improvements to your code that I would consider:
1-Avoid Inline Styles: Move styles from inline HTML attributes to CSS for better separation of concerns.
2-Use IDs Sparingly: Consider using classes instead of IDs for styling elements, especially when styles are shared among multiple elements.
3-Avoid Overly Specific Selectors: Use more general selectors to prevent specificity issues and make the CSS easier to maintain.(no need for doing #smaller1, #smaller2,#smaller3)
4-Semantic HTML: Ensure the HTML structure is semantic and appropriately represents the content. Avoid using that many divs as specially if they are empty.
5-Use CSS Flexbox or Grid: Simplify layout positioning by using CSS Flexbox or Grid instead of absolute positioning where possible. Also never use <br> or to space your html elemnents, It should be done in CSS.
Hope you find this Helpful, Please mark it as helpful if it was :)
Marked as helpful0@sandeep7631Posted 10 months agoThankyou so much @Rami-Hegazy, I was looking for this comment
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord