Design comparison
Solution retrospective
I just need to know if the way I created this code whether it is the best practice or there's something better that I could've done.
Community feedback
- @ernest-ayiteyPosted over 1 year ago
You did a great job... The image tag should be rapped in the <figure> or <picture> tags. This help with SEO(Search Engine Optimization )optimization .
Please read on the following css ( overflow-wrap,inline-size) this help you break a text to the next line. The <br> tag is good but it is not good when you have a lot text to break to the next line.
Hope for you find this helpful.... HAPPY CODING........
Marked as helpful1@BassemNegmPosted over 1 year ago@ernest-ayitey Thank you so much for having the time to provide your feedback on this. I'll keep it in mind for my next project.
0 - @Kamlesh0007Posted over 1 year ago
Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add some code in body tag to make the container center using flexbox not using the margin it is not the correct way
Here's an example code snippet:
body { min-height: 100vh; margin:0; display: flex; text-align: center; align-items: center; }
Marked as helpful1@BassemNegmPosted over 1 year ago@Kamlesh0007 Thank you so much for your feedback, appreciate it. It will help me improve my coding skills for future projects.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord