Skip to content
Submitted 6 months ago

QR Code using HTML and CSS

Shiv•350
@undrthegraveyard
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am not satisfied with how it turned out, it could have been better and would have taken way less time.

Next time, I will definitely think more logically before writing my code in HTML and CSS.

What challenges did you encounter, and how did you overcome them?

Foremost challenge I encountered was to make the image-container look the same as given in the brief, I used ChatGPT to help me with it.

What specific areas of your project would you like help with?

I would love some feedback on my structure of the code. My goal is to write as efficiently as possible.

Community feedback

  • Josh Pickard•130
    @joshpickardmePosted 6 months ago

    You say you are "not satisfied with how it turned out" yet you've produced something that is very close to the design.

    Some very simple improvements that you could make to help you write as efficiently as possible.

    1. Change the HTML element for the text "Improve your front-end skills by building projects" from a <p> to a <h1>. Remove the class attribute from both text elements as it's now no longer needed.
    2. In styles.css you can select h1 and p instead of having selecting classes that are .p1 and .p2. It makes sense semantically that the bolder text is the heading.

    Hope this helps

    Marked as helpful
    0
    Shiv•350
    @undrthegraveyardPosted 6 months ago

    @joshpickardme

    I really appreciate your feedback. I am going to take note of what you said, quite helpful indeed.

    Thank you!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord