Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code using HTML and CSS

Justin 300

@iamprincetj

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

LucasNgTg 190

@LucasNgTg

Posted

Hello there! Well done on completing this challenge!

The proportions on the QR code card look quite accurate. A couple of things you might find helpful, though:

  • In order to keep your code organized, include the styles in a separate CSS file;
  • Always try to give HTML classes meaningful names, that helps with readability and possible maintenance later on;
  • Although the template HTML file contained the attribution divs, the design image did not. In my opinion, the instructions provided were unclear in that regard. However, since you've decided to keep them, consider applying styles that fit the other bits of text, that helps to keep the page cohesive all throughout;
  • Check out flexbox to layout the page elements: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flexible_box_layout

Have a nice day!

0

@teixeirabrenno

Posted

I would say it's perfect. The only thing I would have done is to create a specific file for the CSS.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord