QR code using HTML and CSS

Community feedback

• 

  LucasNgTg•210

  @LucasNgTgPosted 5 months ago

  Hello there! Well done on completing this challenge!

  The proportions on the QR code card look quite accurate. A couple of things you might find helpful, though:

  • In order to keep your code organized, include the styles in a separate CSS file;
  • Always try to give HTML classes meaningful names, that helps with readability and possible maintenance later on;
  • Although the template HTML file contained the attribution divs, the design image did not. In my opinion, the instructions provided were unclear in that regard. However, since you've decided to keep them, consider applying styles that fit the other bits of text, that helps to keep the page cohesive all throughout;
  • Check out flexbox to layout the page elements: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_flexible_box_layout

  Have a nice day!

  0
• 

  teixeirabrenno•70

  @teixeirabrennoPosted 5 months ago

  I would say it's perfect. The only thing I would have done is to create a specific file for the CSS.

  0