QR Code using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100% property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  PATRICK WAFULA MUNUKU•30

  @PatMun22Posted over 1 year ago

  @0xAbdulKhalid I appreciate your input, Abdul. I believe this insight will help me become a better developer. Thanks again

  0
• 

  Khawar Mehfooz•530

  @KhawarmehfoozPosted over 1 year ago

  Hey there! Congratulations on completing the challenge! 🎉

  Regarding your question, using semantic tags in HTML is indeed considered a best practice, even for short projects. Semantic HTML helps improve the accessibility and maintainability of your code. It provides meaning and structure to your content, making it easier for search engines, screen readers, and other tools to understand and navigate your website.

  While it may seem like a negligible difference in smaller projects, using semantic tags sets a good foundation for developing larger projects in the future. It trains us to think in terms of the underlying structure and purpose of the elements we use, which becomes increasingly important as projects grow in size and complexity.

  So, I would definitely recommend incorporating semantic tags in your HTML, even for smaller projects. It's a good habit to develop early on and will benefit you in the long run.

  Once again, well done on completing the challenge, and keep up the great work! If you have any more questions, feel free to ask. Happy coding! 😊

  Marked as helpful

  0

  ---

  

  PATRICK WAFULA MUNUKU•30

  @PatMun22Posted over 1 year ago

  @Khawarmehfooz Thanks, Khawar

  0