Q.R code using flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h2> so it can cause severe accessibility errors due to incorrect usage of level-two headings <h2>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h2> element which is this <h2>Improve your...</h2>, you can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  princeiscoding•70

  @princeiscodingPosted over 1 year ago

  @0xAbdulKhalid .Thanks for the feedback. I was trying to get my solution to look exactly like the design and <h2> seemed like it was the exact size. Based on what you said about assistive technologies, I guess I should use the <h1> and try to scale it down with the font-size property.

  0
• 

  khushboo khatwani•1,070

  @khushi0909Posted over 1 year ago

  1)image should always have alt="some description". some description about image should always be there for accessibility reasons

  2)now it looks good on every screen ,but you can read about media queries for responsiveness for the future

  All the best

  1