QR code using flexbox

HTML:

• The alt text must also say where it leads(frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

• Never have text in divs alone. "Scan the QR code" is a <p>, and it doesn't need to be wrapped in a div.

CSS:

• Including a CSS Reset at the top is good practice.

• I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

• On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

• Remove width and height on the card. You should rarely set fixed sizes in px.

• Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

• font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

• Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

• Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

• On the image, add display: block and max-width: 100% - the max-width prevents it from overflowing its container.

no feedback