QR Code using Flex for alignment

Community feedback

• 

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  This is a very good beginning!

  • You better use a main landmark in this case

  • Import your font-family in the head on the html with a link instead with @import in your css for optimalization reasons

  • Add a css reset look on Andy's Bell website for a good and clear one (use a css reset in every project)

  Marked as helpful

  0

  ---

  

  alphaura•80

  @alphauraPosted over 1 year ago

  @Thewatcher13

  • I didn't use the <main> in this case as there's only one thing, but I understand the reasoning behind as I would keep consistent proper HTML structuring.

  • Searched for the HTML linking of the font-family, and makes sense as it would help me avoid some loading issues of the fonts.

  • Had a look at the CSS reset, and seems like I partially did it, as I usually do it for the box-sizing, body margins and img responsiveness, and the other tags depending on the usage and design of the content.

  Let me know if my understanding and reasoning is good 😀

  0

  

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  • Yeah, but you have always a main thing on your site/project.

  • Indeed you did a reset partially.

  • What is your level of webdev?

  0

  

  alphaura•80

  @alphauraPosted over 1 year ago

  @Thewatcher13

  • Fair enough, will make sure to keep doing proper HTML structure :)
  • If warm-up-dev exists as a term, then it's me haha. Started learning last November through Skillshare, recently finished an Adobe course and will be taking the exam in the coming weeks.

  0

  

  Joachim•840

  @Thewatcher13Posted over 1 year ago

  @alphaura haha okay, I saw it on your code! Again well done!

  1
• 

  Abdallah Aminu Daneji•240

  @waad2lfPosted over 1 year ago

  i hope my feedback is helpful

  0
• 

  Abdallah Aminu Daneji•240

  @waad2lfPosted over 1 year ago

  Nice work, But the background color is slightly different from the design. Also, add font-weight to the paragraph (scan the Qr.......)

  0

  ---

  

  alphaura•80

  @alphauraPosted over 1 year ago

  @waad2lf Thank you for the feedback!

  Since the default font weight is 400, I don't see the requirement for me to also set the font-weight to 400, less code, cleaner code.

  0

  

  Abdallah Aminu Daneji•240

  @waad2lfPosted over 1 year ago

  for sure👍@alphaura

  0