Qr code using display and position css

Community feedback

• 

  Adriano•39,190

  @AdrianoEscarabotePosted about 2 years ago

  Hi @ohad331, how are you?

  You did a great job on this challenge, but I have a few tips I think you'll like:

  1- Document should have one main landmark, you could have put all the content inside the main tag. click here

  2- Page should contain a level-one heading, you could change h2 to h1 click here

  To have a better centering of the .card I put:

  .card { min height: 100vh; }

  I noticed that the card is varying a lot in size as the screen resolution increases, to solve this I put an absolute unit of measurement (px), prioritize the use of relative units (%) only in lower resolutions.

  .Card { width: 320px; height: 500px; }

  The rest is great. Hope it helps... 👍

  Marked as helpful

  0

  ---

  

  Ohad•50

  @ohad331Posted about 2 years ago

  Hi @AdrianoEscarabote, Thank you very much my friend!! Help a lot :)

  1

  

  Adriano•39,190

  @AdrianoEscarabotePosted about 2 years ago

  @ohad331 no problem, keep coding!

  0