QR Code using CSS/HTML

Community feedback

• 

  Mohammed Fakih•1,590

  @javascriptor1Posted 10 months ago

  Hello Madeline0421,

  Good work. I have cloned your repo, updated the code then opened a pull request so you can check how I addressed the issues you raised in your comment.

  Here are some notes about it:

  • how to remove the white space at the top

  The white space is a result of setting a fixed height on the container and then displaying it as flex with center alignment on both axes.

  By removing the fixed height , and adding the right padding , you can control the white space.

  • Structure the font the same as the preview (move the font on a third line).

  You have to use padding from right and left to control such behavior. When you add more padding on X axe, the space available to display the text gets reduced which will result in moving to the third line.

  I hope these notes will help.

  Keep coding and good luck. Rgds, Mohammed

  Marked as helpful

  1

  ---

  

  Madeline0421•20

  @Madeline0421Posted 10 months ago

  @javascriptor1 Thank you so much, this was really helpful! Appreciate it!

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 10 months ago

  Hello @Madeline0421!

  Your solution looks excelent!

  I have just one suggestion:

  • In order to make your HTML code more semantic, use <h1> for the main title instead of <h2>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did a great job!

  Marked as helpful

  1

  ---

  

  Madeline0421•20

  @Madeline0421Posted 10 months ago

  @danielmrz-dev Sounds good! I actually didn't realize that fact about headers. Thanks!

  1
• 

  Codster dev•170

  @codster15Posted 10 months ago

  excellent ....❤️ let's connect

  0