QR Code using css media query

Community feedback

• 

  Flaviu Dragomir•150

  @FlaviuD94Posted about 2 years ago

  Hi, nice to have you around! Welcome to Frontend Mentor Coding community Your solution looks great, you can still do some things to it:

  • replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • you can use the <main> instead of using <section>.
  • for measurement you can use ruler tool from Photoshop.

  I hope it will help you, Enjoy coding!

  Marked as helpful

  0

  ---

  

  Moh Lutfi Fauzi•130

  @MohLutfiFauziPosted about 2 years ago

  @FlaviuD94 At first I thought it didn't fit for the card to have h1 in it, but I realized that there was only 1 component on the page. so there really should be an h1, thanks a lot.

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Moh, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  • Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.
  • Replace the <h2> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.
  • Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.
  • Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

  Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Moh Lutfi Fauzi•130

  @MohLutfiFauziPosted about 2 years ago

  @correlucas thanks for the help, it really helped me as a beginner frontend :)

  0