QR Code Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 11 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  INCORRECT USAGE OF PARAGRAPHS ⚠️:

  • This solution consists lacking of level one heading h1 so it can cause severe accessibility errors due to incorrect usage of paragraph <p>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <p> element which is this <p>Improve your...</p>, you can preferably use <h1> instead of <p>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Good job!

  Here are some comments that may help you:

  • Use semantic tags such as main, footer, figure, etc, this helps the accessibility and SEO of the site
  • The <div class="rectangle"> should be <main class="rectangle">
  • The <div class="attribution"> should be <footer class="attribution">
  • To center the elements in the center of the screen you can make the following adjustments in the body, you must also remove the margin from your rectangle class:

  body {
      background-color: hsl(212, 45%, 89%);
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  
  .rectangle {
      border-radius: 25px;
      height: 525px;
      width: 330px;
      background-color: hsl(0, 0%, 100%);
  }
  

  Marked as helpful

  1
• 

  Ata MLK•100

  @AtaMLKPosted 11 months ago

  nice job

  0