Design comparison
Solution retrospective
I was unsure about how to size the items better. I got around most of it, but it was messy. I'm sure I'll get better with time
Community feedback
- @0xabdulPosted over 1 year ago
Hi
daniel
| Dev | we'll congratulations on completing the QR code component this project you doing very well but some Accessibility reports occurred A Few Feedback for improve your code and clear the issueSolution π
IN HTML π :
L A N D M A R K π
- The main landmark should be a top-level landmark. When a page contains nested document and/or application roles (e.g. typically through the use of iframe and frame elements), each document or application role may have one main landmark. If a page includes more than one main landmark, each should have a unique label.
- To Clear the Accessibility reports use the Semantic elements Or non - Semantic elements
- Note This Elements are don't sikp
- semantic elements :
<aside> , <artical> , <main>, <header> ,<section><footer>, <form> ect..
- non- semantic elements :
<div> , <span> ect ...
- for easy way to clear the Accessibility reports using non semantic elements Ex :
<body> <div class="container" role="main"> // All html code goes here : π </div> </body>
- Or
- using semantic elements
- Ex :
<header> should be put heading or logoπΈ </header> <nav> //Links here </nav> <main> Main of the contents π </main> <footer> Β©copy right hereπ </footer>
HEADINGS βοΈ
- The page must contain at least one
h1
element identifying and describing the main content of the page. Anh1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page so reason Accessibility reports occurred Ex :<h1> must </h1>
I Recommend you Know fully one level headingπ Click here
IN CSS π¨ :
Your QR card is not center aligning it shows top of the Web page π so fix that
Example :
body { display:grid; place-items:center; margin:0; height:100vh; }
I Hope it's useful for you and Happy Coding π€©
0 - @ladyprogrammerPosted over 1 year ago
There are several techniques to center content if you look around. The most recent ones are CSS Flexbox or Grid. Among those I searched online, these two are the ones that helped most.
- [CSS Flexbox] (https://css-tricks.com/snippets/css/a-guide-to-flexbox/)
- [CSS Grid] (https://css-tricks.com/snippets/css/complete-guide-grid/)
I suggest learning CSS Flexbox first as it's easier to grasp before learning the CSS grid as flexbox is simpler.
0 - @visualdennissPosted over 1 year ago
Hello there,
good work! You just need to center the card and import the font families. You can do that by using CSS GRID or CSS FLEXBOX like so:
body { background-color: cadetblue; min-height: 100vh; display: grid; place-items: center; }
For fonts, you can import is with @import, just add this to the top of your css file:
@import url('https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap');
then you can use it like so:
- font-family: 'Outfit', sans-serif;
Hope you find my feedback helpful!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord