Qr Code using CSS flexbox

Community feedback

• 

  Ali Mohamed•60

  @AliMohamed35Posted about 2 months ago

  GreatJob!!

  2
• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted about 2 months ago

  Hi there.

  Congratulations, you have done an excellent job!

  Some of the things you've done well:

  • margin: 1rem on the card(you could also use padding: 1rem on the body) to prevent the card from getting squished on smaller screens.

  • Centering the card using Flexbox and min-height instead of height.

  • No fixed widths or heights in px.

  • max-width in rem on the card to prevent it from getting too wide on larger screens.

  • Setting font-size in rem instead of px, which is vital for accessibility.

  A few suggestions to improve your solution even further:

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • The alt text must also say where it leads(the frontendmentor website). Do not include words like "image" or "photo" , as screen readers announce that by default. A good alt text would be "QR code leading to the Frontend Mentor website."

  • Change .attribution to a <footer>, and move it outside of <main>.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • On the body, add flex-direction: column and gap: 2rem.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • Instead of .text > .text-2, it's better to use a single class selector (.text-2), as this keeps the specificity low and flat.

  Keep up the good work! :)

  1