QR code using CSS Flexbox

Community feedback

• 

  gfunk77•1,200

  @gfunk77Posted about 1 year ago

  Hey Uttam, Nice job on the qr component. It looks great. Looking at your css I'll just point out a couple of things. Widths on block level elements like divs are 100% by default. So for example, you don't really need .container { width: 100vw }. Also, be careful making images width: 100% . Images can get crazy big and pixelated and won't respond the way you want. Try max-width: 100% and that will let the image be more responsive. In this case, with your image being in a div, you can try max-width: 100%, display: block. You don't really need object fit here. Also, generally speaking, try avoiding putting fixed heights on things. On the card, if your margins are correct, the card will be the size it wants to be and look good. Use min-heights like you did for the container. I hope this helps. Well done.

  Marked as helpful

  1

  ---

  

  Uttam Kalaria•40

  @Uttam-PatelPosted about 1 year ago

  @gfunk77 Thank you for your valuable feedback. It was very helpful for me. Looking forward to getting this kind of feedback in the future.

  0