@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- I don't see any negative margin values and I believe they are not necessary.
- You can use the tags you need, just avoid skipping headings elements, start with <h1> and not with <h3>, and you can achieve the same result using font-size in the CSS code.
- You can upload the image to your Github repository, the challenge is not too big and it will not affect performance. Also, by using an external image, you are making an extra request.
- The numbers 375px and 1440px are the dimensions of the images, you don't have to set the width of the body to those values. Otherwise, on 4k screens, your element will not be centered.
- You should not use inline-CSS (CSS in the html code) because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.
- I think you have to upload the images folder and the favicon to your repository.
- There are too many <br> tags, you are cluttering the HTML code a lot, you can achieve the same result using margins.
- Avoid using
position: absolute
to center an element as it may result in overflow on some screen sizes. Instead, utilize the flexbox or grid layout for centering. Get more insights on centering in CSS here here π.
I hope you find it useful! π
Happy coding!
Marked as helpful
@Cyber-Chic
Posted
@MelvinAguilar
This is wonderful feedback!! You cleared up a lot of the initial confusion I had when creating this. I will start implementing these changes to my site. Thank you so much for the great responses to my questions - Very helpful!
I really appreciate your help with this! π
Happy coding!