@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The GitHub repository is private or not available. :(
Background 🌆:
-
You should not recreate the background, you used the image
desktop-preview.jpgto create your solution, but that image is for decoration and is a nice way to present the challenge, for example, you can use it in your github README.You must use the images
desktop-design.jpgandmobile-design.jpgto create your solution.
HTML 📄:
- Use semantic elements such as
<main>and<footer>to improve accessibility and organization of your page.
- The <br> tag is often used to create line breaks, but it doesn't convey any semantic meaning. When a screen-reader reads the text, it will break the flow of reading at the line break tag, which can be confusing for users. More information here.
- You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
altattribute. Thealtattribute should explain its purpose. e.g.QR code to frontendmentor.io
I hope you find it useful! 😄
Happy coding!
Marked as helpful
@djamelBelkheir
Posted
@MelvinAguilar Hello there, I want to thank your for your important response and I almost understood everything you said and I found it useful, but I have two question :
-
The third point of using inline-padding I did not understand it, and it will be better if any video talking about it, because I saw many people use it.
-
In the first point, I though that this project does not need footer or nav elements. So, am I supposed to write it and leave it empty or what ?
Thank you
