Submitted almost 2 years ago

QR code using CSS

Success Daniel• 60

@Rexbrainz

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Product preview card component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hello As a newbie and this being my first project a lot of things were hard to do. I found it difficult to organize my divs as well as define their dimensions as I wanted, I tried working on anther project it was the same which is a clear indication that I need to learn more on how to use margins, paddings, width and height. Every help would be appreciated. I am unsure of how to find appropriate colors, write well structured html codes and managing the dimensions of images and divs. I am open to learning new practices and would appreciate your review on my overall work and things I could do better. I'd also appreciate resources tagged with the review pointing me to good resources that would be helpful in improving my html/css. Looking forward to your reviews Thank you. Best regards, Success

Community feedback

Andrew Kerr• 60

@andrewkerr3956

Posted almost 2 years ago

Hello Daniel,

First of all, the submitted solution does not match this challenge, I'm assuming this was by mistake, so I will be comparing your solution to the QR code challenge.

There is a lack of semantic HTML. Semantic HTML is important for things such as SEO, and a more clean and easy to understand document structure.
Your paragraph id's need more meaningful names. This is so that the purpose of the paragraph tag is clear and is unique.
The background for the body should be an image, which should have been provided to you through the assets downloaded. For that you can use the background-image CSS property

Finally, I would highly recommend going through the responsive web design course on freeCodeCamp. It will teach you a lot of valuable things such as semantic HTML, CSS grid, flexbox, etc. MDN also provides valuable information on everything HTML and CSS, so if you are confused about anything, please check there as well. MDN HTML and MDN CSS.

Hope this helps!

Marked as helpful

Success Daniel• 60

@Rexbrainz

Posted almost 2 years ago

@andrewkerr3956 Thank you Andrew.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord