QR code using basic HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi yAshr, good job! Congratulations on completing the challenge.

  I had a look at your solution and I have a few suggestions for you:

  • remove the margin and top property from card class.
  • remove max-width from body
  • use Flexbox for center the card to the body. Read here -> flex guide
  • add heigth: 100vh to body because Flexbox aligns to the size of the parent container
  • Adding main tag for Accessibility and wrap the card inside

  Hope this help and happy coding :)

  Marked as helpful

  1
• Account deleted

  Hello there! 👋

  Congratulations on finishing your challenge! 🎉

  I have some feedback on this solution:

  • Always Use Semantic HTML instead of div like <main> <header> , etc for more info

  • Remove the position,margin, etc from the card element add to the body these properties to center the card display:flex: justifiy-content; center; align-items:center; min-height:100vh; and remove the max-width from the body

  • Add A Max Width to there paragraph to make it look exactly like the design max-width:240px

  if my solution has helped you do not forget to mark this as helpful!

  Marked as helpful

  1
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! yAshr Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  Keep up the good work!

  0