QR Code using basic html and basic css

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 10 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .border {
     margin: auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  ChaosBlitz404•140

  @ChaosBlitz404Posted 10 months ago

  Thx for the feedback! appreciate it @0xAbdulKhalid

  0
• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 10 months ago

  Hello @ChaosBlitz404!

  Your project looks great!

  I see that you already got help here, but I just have a comment about centering elements:

  • The best option to center an element is what Abdul suggested you on the previous comment, but just for you to know, there is another option:

  You can apply this to the card:

  .element {
      position: absolute;
      top: 50%;
      left: 50%;
      transform: translate(-50%, -50%);
  }
  

  Just be careful with this option because depending on the lenght of the element, part of the content can be cut off on smaller screens in landscape orientation.

  As I said, there's a better option, but it's always nice to know alternative ways to do things 😊

  I hope it helps!

  0