QR code UI for newbies

Community feedback

• 

  BADHRI KESAVA RAJA S M•515

  @BadhrikrPosted over 2 years ago

  apply body{ min-heigth: 100vh; }

  This will bring your container to center.

  Marked as helpful

  1

  ---

  

  Moad•10

  @0xMoadPosted over 2 years ago

  @Badhrikr thanks for the tip man!

  0

  

  Simon Adanu Ogiji•50

  @saogijiPosted over 2 years ago

  @Badhrikr Thanks for this nice trick! I'll apply to my work!

  0
• 

  mubizzy•1,520

  @mubizzyPosted over 2 years ago

  Excellent job on this challenge! your report has a few issues though:

  1. wrap everything in your body in <main> or use semantics

  2.   it is a best practice to use both HTML 5 and ARIA landmarks to ensure all     content is contained within a navigational region.

  Hope it helps:)...don't forget to mark it as helpful 👍

  You can get more details here...click here

  0
• 

  Simon Adanu Ogiji•50

  @saogijiPosted over 2 years ago

  @0xMoad Great work, you still need to center the project vertically, trying using css position property that's what I used for this project, though there are other methods such as flexbox that can be used to achieve same result. @Jonyango suggested a source https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Flexbox I think you should check it out!

  0

  ---

  

  Moad•10

  @0xMoadPosted over 2 years ago

  @saogiji appreciate the help! I've actually centered my card if you check my styles.css on github :) Seems like the live preview won't show that change? Works in vscode :)

  0