Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Task

jadilovic 210

@jadilovic

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Ecem Gokdogan 9,380

@ecemgo

Posted

Some recommendations regarding your code that could be of interest to you. 🤗

HTML

In order to fix the accessibility issues

  • Each main content needs an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a <h1> element in the <main> tag instead of using the <h2> element. You can replace the <h2>Improve your front-end skills by building projects</h2> element with the <h1>Improve your front-end skills by building projects</h1> element.

CSS

  • If you want to center it, you can add these flex features to your body
body {
    flex-direction: column;
    align-items: center;
    min-height: 100vh;
    background-color: hsl(212, 45%, 89%);
}
  • then you need to update your .container and .attributionin this way:
.container {
     width: 100%;
     max-width: 350px;
     display: flex;
     justify-content: center;
      align-items: center;
}
.attribution {
    position: absolute;
    bottom: 0;
    font-size: 16px;
    text-align: center;
}

Hope I am helpful. :)

Marked as helpful

0

jadilovic 210

@jadilovic

Posted

@ecemgo Thanks!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord