Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Submission

#semantic-ui
Ryan Parsleyβ€’ 10

@RyanParsley

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello world! For my first submission I wanted to keep the tech stack at a minimum. No sense complicating things more than the brief requires.

Community feedback

Travolgi πŸ•β€’ 31,440

@denielden

Posted

Hi Ryan, congratulations on completing the challenge, great job! 😁

Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from card class because with flex they are superfluous
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px or % use relative units of measurement like rem -> read here

Hope this help! Happy coding πŸ˜‰

Marked as helpful

0

Ryan Parsleyβ€’ 10

@RyanParsley

Posted

@denielden Thanks for that! I was a bit myopic on matching the jpgs and lost sight of some accessibility wins. I appreciate you taking time to help me out.

1
Travolgi πŸ•β€’ 31,440

@denielden

Posted

@RyanParsley You are welcome and keep it up :)

0
Lucas πŸ‘Ύβ€’ 104,500

@correlucas

Posted

πŸ‘ΎHi @RyanParsley, congratulations on your first solution!πŸ‘‹ Welcome to the Frontend Mentor Coding Community!

Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

1.To save your time you can code your whole page using px and then in the end use a VsCode plugin called px to rem here's the link β†’ https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

2.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

3.Save your time using a CSS RESET to remove all default settings that are annoying as the margins, paddings, and decorations and optimize it making it easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

✌️ I hope this helps you and happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord