Design comparison
Solution retrospective
Wondering if there's anything I should have structured better in terms of the styles.
This one is basic, so I thought there was no need to play around with any frameworks or SASS.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @stashix!
Your solution looks excelent!
I have just one suggestion:
- In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h3>
. Unlike what most people think, it's not just about the size and weight of the text.
📌 The
<h1>
to<h6>
tags are used to define HTML headings.📌
<h1>
defines the most important heading.📌
<h6>
defines the least important heading.📌 Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.This change has little or not effect at all on the project, but it makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, you did a great job!
Marked as helpful0 - In order to make your HTML code more semantic, use
- @Zy8712Posted 10 months ago
Hey there! Your site looks great!
One minor mistake I noticed glancing at your html code is that you are missing a closing main tag
</main>
and you have two closing</div>
tags instead (I'm guessing you changed a div to main part way though the project).Besides that and the changes to be made to your header, I'd say your code and site are pretty solid. Nice work 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord