QR code starter challenge

Community feedback

• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Excellent work 👍, but I have a suggestion!

  • Replace height: 98vh to min-height: 100vh in the body, the difference is that, when you set height: 98vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it!

  Marked as helpful

  0

  ---

  

  joshua-gibson•90

  @joshua-gibsonPosted over 1 year ago

  @lack21 Thanks for your comment! I set this to 98vh instead of 100vh because at 100, the attribution goes off the bottom of the screen. Any idea why that might be the case? As it is contained in the body, I'd have thought it would not have gone past.

  1

  

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  @joshua-gibson You have to add margin: 0 to the body as well, it will remove all unnecessary space!

  Marked as helpful

  0

  

  joshua-gibson•90

  @joshua-gibsonPosted over 1 year ago

  @lack21 Thanks!

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.

  ---

  • The alt with QR Code is not even explaining for what the QR image need to be used.

  ---

  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

  ---

  • Example: <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

  ----.

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0