QR code speedrun

Community feedback

• 

  Eric Salvi•1,350

  @ericsalviPosted about 2 years ago

  WOW... great job on the challenge of trying to get it completed in less than 1 hour.

  Your HTML is super semantic and your CSS is small. I can't find any issues at all so I'll try to maybe offer suggestions for future challenges.

  If you want to stick with CSS try to run your CSS through the vendor prefix tool here

  If you stick with CSS, look for opportunities to use CSS variables.

  Try setting the base font size on the body and then use REM units.

  Try something a bit different by using a CSS preprocessor such as SCSS. This tool will do the vendor prefixes automatically.

  Lastly, I have been trying to constantly use GitHub pull requests for milestones when working on these challenges. Really helps me to get more comfortable with that platform.

  Cannot wait to see your next one!

  Marked as helpful

  1