Design comparison
Community feedback
- @glowri57Posted about 2 months ago
Hi @Thomas-Ngo-1
Here's what I noticed:
- font-weight have values 100, 200, 300...900, you don't need to add px
- add some space at the bottom of your paragraph
- the paragraph should have color Slate 500
- Since you styled the class
.slate-300and the rest, the property should be defined in your HTML file. Here's an example:
<span class="slate-500">...</span>Then the color assigned to slate-500 would be styled on the span tag.
- The
background-color:in those color classes should be changed tocolor:You're trying to define the color of the text, not the background-color of the text.
I hope you find this helpful!
0 - @StroudyPosted about 2 months ago
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
-
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Overusing
<div>tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like<header>,<section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.
<div> <img style="border-radius: 1rem;" src="static/images/image-qr-code.png" alt="QR-Code" width= "100%"> </div>- These
<div>should really have semantic tags like headings (<h1> to <h6>) and paragraphs (<p>) convey structure and meaning to content, improving accessibility, SEO, and readability by helping search engines and screen readers interpret the content.
<span>Scan the QR code tasdoas visit Frontend Mentor and take your coding skills to the next level</span>-
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
While
pxis useful for precise, fixed sizing, such asborder-width,border-radius,inline-padding, and<img>sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpxfor font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likeremand adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepxwhere exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
0 -
- @CptnRedbeardPosted about 2 months ago
Font colors should be the Slate 900 (heading) and Slate 500 (paragraph).
Sizing should be adjusted because the entire solution is a bit smaller than the design
Perhaps use padding to ensure text wraps like the design.
Add a bit more empty space at the bottom.
In the mobile view, you appear to have too much spacing on the sides.
Nice job!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord