Design comparison
SolutionDesign
Solution retrospective
I'm curious if using the dialog element is the best element to wrap the main content for this challenge.
Community feedback
- @denieldenPosted almost 3 years ago
Hi Claire , good work!
The best element to wrap the main content in general is
main
tagThe image is broken because have a slash before in the src link:
<img alt="QR Code" src="/images/image-qr-code.png"> remove slash <img alt="QR Code" src="images/image-qr-code.png">
Hope this help ;)
1 - @kacperkwintaPosted almost 3 years ago
Wow, this is the first time I see a
<dialog>
tag! I think there is no need to use this tag, you can use a simplediv
Some tips:
- don't use
px
forfont-size
, here's why - the path to the image is incorrect, as you can see, it doesn't show
- add a little
box-shadow
to the box, as you can see in the design
0 - don't use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord