Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Solution using HTML, SASS and Grid

@Jack-Price

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@KoiHast

Posted

Hey, great job on your first project! If you want, here are just a couple of tips to improve your code a bit ^_^

  • You want to wrap the main part of your HTML in a <main> element, just to improve semantics and readability.

  • Just to clean up your code, since you deleted the div.attribution from the bottom, you could delete the section of your HTML that pertained to that, as well. It would just make things a bit neater since that code isn't being used anymore.

I'd analyze your CSS, but I'm still learning a lot of those rules myself, so I don't want to steer you wrong. I hope the HTML tips help you out, though! 🌺✌

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord