@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π:
- The text
Improve Your Front-End Skills by Building Projects
is considered a heading element.
- Use semantic elements such as
<main>
to improve accessibility and organization of your page.
Alt text π·:
-
The
alt
attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteralt
attribute would beQR code to frontendmentor.io
If you want to learn more about the
alt
attribute, you can read this article. π.
CSS π¨:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. You can read more about this here π.
- To center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here π.
body {
background-color: hsl(212, 45%, 89%);
font-family: "Outfit", sans-serif;
text-align: center;
min-height: 100vh;
display: grid;
place-content: center;
}
.main {
/* margin: 100px auto; */
}
- You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
@sagehands101
Posted
@MelvinAguilar thanks a lot
I'm 2weeks into my coding journey as a beginner, this really helped and I'll work on those points