@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 🏷️:
- The text 'Scan the QR code to visit Frontend Mentor and take your coding skills to the next level' is a simple paragraph and not a heading (h2).
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
CSS 🎨:
- Instead of using a defined height (
height: 800px;
), you can usemin-height
with a value of100vh
to make the section take up the full height of the viewport regardless of the device.
CSS Reset 🔄:
-
You should use a CSS reset. A CSS reset is a set of CSS rules that are applied to a webpage in order to remove the default styling of different browsers.
CSS resets that are widely used:
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!