QR code solution using html and css

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to add some code in body tag to make the container center

  Here's an example code snippet:

  body
  { 
  min-height: 100vh;
  display: flex; 
  text-align: center; 
  align-items: center;
  }
  

  And also You need to add background color to body to make background as per design

  body
  {
  background:hsl(212, 45%, 89%);
  }
  

  Marked as helpful

  0

  ---

  

  TrayceSA•20

  @TrayceSAPosted over 1 year ago

  Thank you @Kamlesh0007

  0
• 

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  TrayceSA•20

  @TrayceSAPosted over 1 year ago

  Thank you@0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,480

  @0xabdulkhaliqPosted over 1 year ago

  @TrayceSA Glad you found it helpful ! 🤠

  0