@PhoenixDev22
Posted
Hi Luz De La Rosa,
Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:
- In my opinion, the alternate text should indicate where the Qr code navigate the user : like
QR code to frontend mentor.
(not describes the image)
- Adding rel="noopener" or rel="noreferrer" to target="_blank" links. When you link to a page on another site using
target=”_blank”
attribute , you can expose your site to performance and security issues.
- There are some unnecessary div’s, needed to be removed
Overall Excellent work! Hopefully this feedback helps.
Marked as helpful
@Razha90
Posted
@PhoenixDev22 hay 😁😁
@luztherose
Posted
@PhoenixDev22 Thank you so much for your feedback :) This will definitely make this and future projects better.
@luztherose
Posted
@PhoenixDev22 I found this information about the rel="noopener"
Note: Setting target="_blank" on <a> elements now implicitly provides the same rel behavior as setting rel="noopener" which does not set window.opener.
https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener