QR code solution - no flexbox or grid

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi George, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • remove all margin from .card class
  • remove all padding from body
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1
• 

  Minh Khang Tran•510

  @MinhKhangTranPosted over 2 years ago

  Hi George, nice solution!

  If you want to center your card you can use flexbox on your body.

  For example:

  body{
      display: flex;
      min-height: 100vh;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  For this to work you should delete your margins and paddings.

  on your body: padding: 85px 25px; => padding: 0;

  on your .card: margin: 110px auto; => margin:0;

  I hope this helped.

  Happy Coding and having fun doing it.

  Marked as helpful

  1