Frontend Mentor | Qr code Solution coding challenge solution

Community feedback

@GodoiTheCreator

Posted over 1 year ago

Código muito bom, amigo, parabéns!
Só cuida para sempre ter uma tag <title> nos seus websites.
E um detalhezinho que seria a cor estar diferente da do modelo da solução, mas isso não quer dizer que está ruim!

Marked as helpful

@GlitzDev

Posted over 1 year ago

@GodoiTheCreator vlw pela dica <3

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

ESSENTIALS ♻️:

This solution has generated accessibility error reports due to lack of title tag inside html element

The title must be text-only, and it is shown in the browser's title bar or in the page's tab.

The <title> tag is required in HTML documents, The contents of a page title is very important for search engine optimization (SEO)

HEADINGS ⚠️:

And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

Every site must want at least one h1 element identifying and describing the main content of the page.

An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

iMAGES 📸:

Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

Rafael• 160

@StomperHK

Posted over 1 year ago

Boa man, o primeiro de muitos.

@GlitzDev

Posted over 1 year ago

@StomperHK com certeza kkk, vlw cara <3

Qr code Solution