Design comparison
SolutionDesign
Solution retrospective
Essa foi meu primeiro desafio concluído! Seu feedback será bem vindo ! <3
Community feedback
- @GodoiTheCreatorPosted over 1 year ago
-
Código muito bom, amigo, parabéns!
-
Só cuida para sempre ter uma tag <title> nos seus websites.
-
E um detalhezinho que seria a cor estar diferente da do modelo da solução, mas isso não quer dizer que está ruim!
Marked as helpful1 -
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
ESSENTIALS ♻️:
- This solution has generated accessibility error reports due to lack of
title
tag insidehtml
element
<html>
element must have atitle
tag, so fix it by adding<title>QR code component</title>
inside thehtml
- The
<title>
tag defines the title of the document.
- The
title
must be text-only, and it is shown in the browser's title bar or in the page's tab.
- The
<title>
tag is required in HTML documents, The contents of a page title is very important for search engine optimization (SEO)
HEADINGS ⚠️:
- And, this solution has also generated accessibility error report due to lack of level-one heading
<h1>
- Every site must want at least one
h1
element identifying and describing the main content of the page.
- An
h1
heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
- So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a
sr-only
class to hide it from visual users (it will be useful for visually impaired users)
iMAGES 📸:
- Since this component involves scanning the QR code, the image is not a decoration, so it must have an
alt
attribute.
- The
alt
attribute should explain its purpose.
- E.g.
alt="QR code to frontendmentor.io"
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord