QR Code Solution

Community feedback

• 

  RobinsonGabriel•60

  @RobinsonGabrielPosted 6 months ago

  Hi JAMB,

  I copy-pasted the solution onto my editor because it's doing something weird on the .io site still where it won't render the qr code. Seems it hasn't updated to include the path in your github code just yet. Looks great when run though!

  Have you put CSS in a separate file yet? I would encourage it just because it can be a bit hard to read/update inline js/css especially when it gets over a few lines. Granted this is just for a prototype component so it's not the end of the world or anything.

  0

  ---

  

  JAMBallou•10

  @JAMBallouPosted 6 months ago

  @RobinsonGabriel Thanks for your feedback! I do not have very much experience using GitHub and Frontend Mentor, so I did not know why the image did not render. I use VS Code and its Live Server extension to view HTML, and it worked perfectly on there. If you could help me fix the image of GitHub, that would be very helpful.

  0

  

  RobinsonGabriel•60

  @RobinsonGabrielPosted 6 months ago

  @JAMBallou Ain't nothing wrong with that, you have to start sometime! (I'm not great with github either, I have a painful amount of junk code on my computer I really need to clear out.)

  Any rate, just comparing your first commit to the live site it honestly just looks like the site itself hasn't updated. It should be fully committed though (if you're practicing with the git command line it probably wouldn't hurt to see if you pushed it though.)

  One thing I just thought of: on the main page for your repo (https://github.com/YOURE_USERNAME/YOUR_REPO) you'll see a little green checkmark right above the panel with all the files in it, next to the little icon with your picture. If you click it, it'll tell you if Jekyll successfully built everything. Does it have anything odd there?

  0

  

  JAMBallou•10

  @JAMBallouPosted 6 months ago

  @RobinsonGabriel I do not see it.

  0

  

  RobinsonGabriel•60

  @RobinsonGabrielPosted 6 months ago

  @JAMBallou

  That tracks,

  Take a look here:

  https://github.com/JAMBallou/frontend-mentor-QR-code-challenge/actions/workflows/pages/pages-build-deployment

  Sometimes a job will get stuck, so if you see a red "x" by a run, it just got stuck. The three dot menu on the far right of the deployment status pill thing should have an option to retry/rerun it not sure if you see it on your end and I don't, but if you can't get it to run again you could try: -Go to settings >code and automation > pages > Github Pages > ... >Unpublish site -While still on here go down to branch, change to none, save. Change it back to the master branch and that triggers the job to rerun also, but it'll use your newest commit.

  At least on my end I only see that one deployment, so you likely did nothing wrong, github just got stuck for one reason or another.

  If that fails, this thread seems to still be up to date and have a few good ideas

  https://github.com/orgs/community/discussions/19713

  0