Skip to content
Submitted 4 months ago

QR Code Solution

Alingggg•150
@Alingggg
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Testing my HTML and CSS skills. Happy that I finished this challenge. Hoping to finish more of these

What challenges did you encounter, and how did you overcome them?

I had problems with zooming and elements overflowing. Fixed them by fixing the width

What specific areas of your project would you like help with?

Hoping for some feedback about my solution. Also the formatting of my CSS (properties etc...)

Community feedback

  • Boris•2,850
    @mkborisPosted 4 months ago

    Hi Alingggg great job completing your first challenge, here are a few things to review

    • All content should be wrapped within landmarks. Wrap a main tag around #plane
    • Every page should have at least one heading typically an h1 element to provide a clear structure. The first p should be a Heading element
    • It's generally better to use classes for most styling due to their flexibility and reusability. IDs are more suited for unique, specific cases where higher specificity is required.
    • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
    • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.

    Hope this helps

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord