Frontend Mentor | QR code site coding challenge solution

@Islandstone89

Posted about 1 month ago

HTML:

Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .container into a <main>.
The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."
I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.
.attribution should be a <footer>, and you should use <p> for the text inside.
Move the footer out of the main, so they become siblings.

CSS:

Including a CSS Reset at the top is good practice.
I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.
Move the properties on .container to body. Change height to min-height, and add gap: 2rem to create some space between the main and the footer.
Remove the fixed width in px on the card. Except for icons, you rarely want to set fixed dimensions(especially heights), as this easily creates issues with responsiveness.
Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.
font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.
Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.
On the image, add display: block and change width to max-width.
Remove the absolute positioning on the footer.

QR code site