Skip to content
Submitted about 2 years ago

QR Code Simple Solution by a Newbie

therapy181•20
@therapy181
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I am open to critics as I am a newbie. I have been learning for a couple of days now, just from reading and Youtube.

Community feedback

  • Vanza Setia•27,755
    @vanzasetiaPosted about 2 years ago

    Hi there! 👋

    Congratulations on finishing your first Frontend Mentor challenge! 🎉

    First, I recommend using a code-formatter. This way, your code base will have a consistent format, which makes it easier to read the code. I suggest using Prettier as your code-formatter.

    Prettier · Opinionated Code Formatter

    Then, I recommend improving the alternative text by:

    • Not hyphenating it: alternative text will be read by humans. So, it should not be like code.
    • Describing the QR code: alternative text is used as an alternative way to understand the image. If the image fails to load, the users should be able to understand the image. In this case, it should tell the purpose of the QR code.

    I recommend removing all <br> elements. Screen readers may read out <br> elements as "break" and not read the content within <br>s. Let lines wrap where they need to. Learn about the accessibility concern when using <br> element — <br>: The Line Break element - HTML: HyperText Markup Language | MDN #accessibility_concerns

    I hope this helps. Happy coding! 😄

    Marked as helpful
    1
  • Sumanth Chandana•720
    @sumanth-chandanaPosted about 2 years ago

    Hi mate!, congrats🎉 on completing the challenge. Better take care about following points.

    • Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings.
    • Use the alt (alternate text) attribute as mentioned in your Accessibility Report. alt attribute is used for Screen readers applications.
    • Why does alt attribute matter? Read here.
    • To avoid accessibility issues "All page content should be contained by landmarks" use code as :
     <body>
    <main>
        ---your code here----
    </main>
  <footer>
  </footer>
</body>

    (why does <main> matter? Read here )

    • For proper centering the container(whole card) vertically and horizontally you can also use the following simple block of code use code:
    body{
display: flex;
align-items: center;
justify-content: center;
height: 100%;
}

    or

    body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}
    • When we open the GitHub repository link, you will find an About Section on the right side. There, also include a live preview link of your project. It is better for someone to check your live project while interacting with code.

    I hope you will find this Feedback Helpful.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord