i would like to know if there is a more better approach to this project. thank you in advance.
@Mxrius1403
Posted
I'm new but I think this would help. You need to set an alt="" tag at the picture sth like alt="QR code which leads to frontendmentor.io" because it isn't a decoration element.
@AtishJoottun
Posted
@Mxrius1403 thank you for the feedback. I greatly appreciate it
@Hassiai
Posted
Replace <div class="container"> with the main tag, <div class="bold-text"> with <h1> and <div class="text"> with <p> to fix the accessibility issues. click here for more on web-accessibility and semantic html
For a responsive content replace the width of .container with max-width and give the img a max-width of 100%.
Give h1 and p the same font-size of 15px and the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
@AtishJoottun
Posted
@Hassiai thank you for the feedback. I greatly appreciate it.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
