Frontend Mentor | QR Code Scanner Solution coding challenge solution

Community feedback

@akramAdjab

Posted about 2 years ago

Hello Matt 🙋🏻‍♂️, Congrats on completing this challenge

I checked your code solution for this challenge, and I found very small errors

Your component it's bigger because of the @media query you wrote, it replaces the max-width of the wrapper class. So to fix your problem, try deleting it

@media (min-width: 768px) {
    .code-container {
        max-width: 1440px;
    }
}

I hope my feedback was helpful 🙌🏻

Marked as helpful

Matt Hummel• 40

@matthummeldev

Posted about 2 years ago

@akramAdjab thank you.

Akram Adjab• 380

@akramAdjab

Posted about 2 years ago

@mattrhummel my pleasure 🙌🏻

Lucas 👾• 104,440

@correlucas

Posted about 2 years ago

👾Hi Matt Hummel, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and great start! By what I saw you’re on the right track. I’ve few suggestions to you that you can consider to add to your code:

1.Add the correct size to avoid the container growing more than it should. In this case the QR CODE component size is max-width: 320px.

2.Use units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

3.The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

✌️ I hope this helps you and happy coding!

Marked as helpful

Matt Hummel• 40

@matthummeldev

Posted about 2 years ago

@correlucas Thanks for the feedback. I think I do tend to use too many elements at times.

QR Code Scanner Solution

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community