Design comparison
Solution retrospective
Here is my solution for the QR Code Scanner. Feel free to provide any feedback or improvements I can make.
Community feedback
- @akramAdjabPosted about 2 years ago
Hello Matt ππ»ββοΈ, Congrats on completing this challenge
I checked your code solution for this challenge, and I found very small errors
- Your component it's bigger because of the
@media query
you wrote, it replaces themax-width
of thewrapper class
. So to fix your problem, try deleting it
@media (min-width: 768px) { .code-container { max-width: 1440px; } }
I hope my feedback was helpful ππ»
Marked as helpful0 - Your component it's bigger because of the
- @correlucasPosted about 2 years ago
πΎHi Matt Hummel, congratulations for your first solution!π Welcome to the Frontend Mentor Coding Community!
Great solution and great start! By what I saw youβre on the right track. Iβve few suggestions to you that you can consider to add to your code:
1.Add the correct size to avoid the container growing more than it should. In this case the QR CODE component size is
max-width: 320px
.2.Use units as
rem
orem
instead ofpx
to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.3.The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary
<div>
. For this solution you wrap everything inside a single block of content using<div>
or<main>
(better option for accessibility) and put inside the whole content<img>
/<h1>
and<p>
.<body> <main> <img src="./images/image-qr-code.png" alt="Qr Code Image" > <h1>Improve your front-end skills by building projects</h1> <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p> </main> </body>
βοΈ I hope this helps you and happy coding!
Marked as helpful0@matthummeldevPosted about 2 years ago@correlucas Thanks for the feedback. I think I do tend to use too many elements at times.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord